-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microdata Support in EM translator #1660
base: master
Are you sure you want to change the base?
Conversation
Great! I´ll review this bit-by-bit. One thing I'm concerned about in general terms is whether we're expecting microdata for multiple items on a page. My understanding of the format is that when I, e.g., cite a book in an article I could use this to embed citation information for the book.
|
Yes, that is possible (but I haven't seen citations encoded in microdata so far) My test cases for developing this translator were the translators already using The detection of EM is not changed and therefore the microdata does not influence the detection in EM. The cases were it could go worse than before are therefore cases were we already now detect a single item but the microdata there now correspond to multiple items. What may be really tricky is the creation of the (There are two debug statements which you can comment out, to see some more information about the statements and the types.) |
This needs further testing. I see some strange behavior e.g. in Springer translator now, which depends on EM. |
@zuphilip interesting what was the problem with Springer? I'm trying to understand what potential issues we can possibly encounter by adding support for more metadata types to EM translator. |
@mrtcode Sorry, I can't remember. But one can try to check out the branch and test the detection/extraction with the Springer website again. |
This superseeds #1068 and support for microdata was asked in #366. Now, with the schema.org ready in RDF translator, I tried to integrate the microdata functionalities into EM translators and adjusted them a little. Currently, this already works on a few examples I used. More testing is needed and any comment is welcome.